[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 19/21] osdep: remove use of socket_error() fr
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v1 19/21] osdep: remove use of socket_error() from all code |
Date: |
Wed, 9 Mar 2016 18:59:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 09/03/2016 18:28, Daniel P. Berrange wrote:
> diff --git a/util/oslib-win32.c b/util/oslib-win32.c
> index b8c9cbe..77db075 100644
> --- a/util/oslib-win32.c
> +++ b/util/oslib-win32.c
> @@ -124,13 +124,13 @@ void qemu_set_block(int fd)
> {
> unsigned long opt = 0;
> WSAEventSelect(fd, NULL, 0);
> - ioctlsocket(fd, FIONBIO, &opt);
> + ioctl(fd, FIONBIO, &opt);
> }
>
> void qemu_set_nonblock(int fd)
> {
> unsigned long opt = 1;
> - ioctlsocket(fd, FIONBIO, &opt);
> + ioctl(fd, FIONBIO, &opt);
> qemu_fd_register(fd);
> }
These should have been in patch 18, but see my answer to patch 17.
Paolo
- [Qemu-devel] [PATCH v1 13/21] char: ensure listener socket is in blocking mode when waiting, (continued)
- [Qemu-devel] [PATCH v1 13/21] char: ensure listener socket is in blocking mode when waiting, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 15/21] char: remove socket_try_connect method, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 17/21] osdep: add wrappers for socket functions, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 16/21] char: remove qemu_chr_open_socket_fd method, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 19/21] osdep: remove use of socket_error() from all code, Daniel P. Berrange, 2016/03/09
- Re: [Qemu-devel] [PATCH v1 19/21] osdep: remove use of socket_error() from all code,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v1 18/21] osdep: remove use of Win32 specific closesocket/ioctlsocket, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 20/21] osdep: remove direct use of qemu_socket & qemu_accept, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 21/21] error: ensure errno detail is printed with error_abort, Daniel P. Berrange, 2016/03/09
- Re: [Qemu-devel] [PATCH v1 00/21] Multiple fixes & improves to QIOChannel & Win32, Paolo Bonzini, 2016/03/09