[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 18/21] osdep: remove use of Win32 specific cl
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v1 18/21] osdep: remove use of Win32 specific closesocket/ioctlsocket |
Date: |
Thu, 10 Mar 2016 14:53:28 +0000 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Mar 09, 2016 at 05:28:21PM +0000, Daniel P. Berrange wrote:
> Now that QEMU replaces the close() and ioctl() methods with
> a wrapper that can transparently handle both sockets and
> regular file handles on Win32, there is no need to ever
> use the closesocket/ioctlsocket methods. The code can simply
> use the normal POSIX methods.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> block/sheepdog.c | 36 ++++++++++++++++++------------------
> include/qemu/sockets.h | 4 ----
> io/channel-socket.c | 2 +-
> migration/qemu-file-unix.c | 2 +-
> migration/tcp.c | 4 ++--
> net/socket.c | 20 ++++++++++----------
> slirp/ip_icmp.c | 2 +-
> slirp/misc.c | 4 ++--
> slirp/slirp.h | 2 --
> slirp/socket.c | 2 +-
> slirp/tcp_subr.c | 6 +++---
> slirp/udp.c | 2 +-
> util/qemu-sockets.c | 12 ++++++------
> 13 files changed, 46 insertions(+), 52 deletions(-)
Given feedback from Paolo on the previous patch, I'm dropping this
patch.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- [Qemu-devel] [PATCH v1 15/21] char: remove socket_try_connect method, (continued)
- [Qemu-devel] [PATCH v1 15/21] char: remove socket_try_connect method, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 17/21] osdep: add wrappers for socket functions, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 16/21] char: remove qemu_chr_open_socket_fd method, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 19/21] osdep: remove use of socket_error() from all code, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 18/21] osdep: remove use of Win32 specific closesocket/ioctlsocket, Daniel P. Berrange, 2016/03/09
- Re: [Qemu-devel] [PATCH v1 18/21] osdep: remove use of Win32 specific closesocket/ioctlsocket,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH v1 20/21] osdep: remove direct use of qemu_socket & qemu_accept, Daniel P. Berrange, 2016/03/09
- [Qemu-devel] [PATCH v1 21/21] error: ensure errno detail is printed with error_abort, Daniel P. Berrange, 2016/03/09
- Re: [Qemu-devel] [PATCH v1 00/21] Multiple fixes & improves to QIOChannel & Win32, Paolo Bonzini, 2016/03/09