[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v1 06/18] io: set correct error object in background
From: |
Daniel P. Berrange |
Subject: |
[Qemu-devel] [PULL v1 06/18] io: set correct error object in background reader test thread |
Date: |
Fri, 11 Mar 2016 10:03:56 +0000 |
The reader thread was accidentally setting the error pointer
intended for the writer thread. If both threads set errors
this would result in QEMU abort'ing due to the error already
being set.
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>
---
tests/io-channel-helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/io-channel-helpers.c b/tests/io-channel-helpers.c
index 8440669..d513792 100644
--- a/tests/io-channel-helpers.c
+++ b/tests/io-channel-helpers.c
@@ -132,7 +132,7 @@ static gpointer test_io_thread_reader(gpointer opaque)
if (ret == QIO_CHANNEL_ERR_BLOCK) {
if (data->blocking) {
- error_setg(&data->writeerr,
+ error_setg(&data->readerr,
"Unexpected I/O blocking");
break;
} else {
--
2.5.0
- [Qemu-devel] [PULL v1 00/18] Merge I/O channel fixes for Win32, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 05/18] io: wait for incoming client in socket test, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 02/18] io: use bind() to check for IPv4/6 availability, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 06/18] io: set correct error object in background reader test thread,
Daniel P. Berrange <=
- [Qemu-devel] [PULL v1 07/18] io: assert errors before asserting content in I/O test, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 01/18] osdep: fix socket_error() to work with Mingw64, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 04/18] io: bind to socket before creating QIOChannelSocket, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 03/18] io: initialize sockets in test program, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 09/18] io: pass HANDLE to g_source_add_poll on Win32, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 08/18] io: fix copy+paste mistake in socket error message, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 10/18] io: introduce qio_channel_create_socket_watch, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 12/18] io: remove checking of EWOULDBLOCK, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 11/18] io: use qemu_accept to ensure SOCK_CLOEXEC is set, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 14/18] char: remove qemu_chr_finish_socket_connection method, Daniel P. Berrange, 2016/03/11