[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v1 11/18] io: use qemu_accept to ensure SOCK_CLOEXEC
From: |
Daniel P. Berrange |
Subject: |
[Qemu-devel] [PULL v1 11/18] io: use qemu_accept to ensure SOCK_CLOEXEC is set |
Date: |
Fri, 11 Mar 2016 10:04:01 +0000 |
The QIOChannelSocket code mistakenly uses the bare accept()
function which does not set SOCK_CLOEXEC.
Signed-off-by: Daniel P. Berrange <address@hidden>
---
io/channel-socket.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/io/channel-socket.c b/io/channel-socket.c
index 775bb9f..9b5f2d8 100644
--- a/io/channel-socket.c
+++ b/io/channel-socket.c
@@ -343,8 +343,8 @@ qio_channel_socket_accept(QIOChannelSocket *ioc,
retry:
trace_qio_channel_socket_accept(ioc);
- cioc->fd = accept(ioc->fd, (struct sockaddr *)&cioc->remoteAddr,
- &cioc->remoteAddrLen);
+ cioc->fd = qemu_accept(ioc->fd, (struct sockaddr *)&cioc->remoteAddr,
+ &cioc->remoteAddrLen);
if (cioc->fd < 0) {
trace_qio_channel_socket_accept_fail(ioc);
if (socket_error() == EINTR) {
--
2.5.0
- [Qemu-devel] [PULL v1 02/18] io: use bind() to check for IPv4/6 availability, (continued)
- [Qemu-devel] [PULL v1 02/18] io: use bind() to check for IPv4/6 availability, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 06/18] io: set correct error object in background reader test thread, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 07/18] io: assert errors before asserting content in I/O test, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 01/18] osdep: fix socket_error() to work with Mingw64, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 04/18] io: bind to socket before creating QIOChannelSocket, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 03/18] io: initialize sockets in test program, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 09/18] io: pass HANDLE to g_source_add_poll on Win32, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 08/18] io: fix copy+paste mistake in socket error message, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 10/18] io: introduce qio_channel_create_socket_watch, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 12/18] io: remove checking of EWOULDBLOCK, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 11/18] io: use qemu_accept to ensure SOCK_CLOEXEC is set,
Daniel P. Berrange <=
- [Qemu-devel] [PULL v1 14/18] char: remove qemu_chr_finish_socket_connection method, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 13/18] io: implement socket watch for win32 using WSAEventSelect+select, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 15/18] char: remove socket_try_connect method, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 16/18] char: remove qemu_chr_open_socket_fd method, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 17/18] osdep: add wrappers for socket functions, Daniel P. Berrange, 2016/03/11
- [Qemu-devel] [PULL v1 18/18] osdep: remove use of socket_error() from all code, Daniel P. Berrange, 2016/03/11
- Re: [Qemu-devel] [PULL v1 00/18] Merge I/O channel fixes for Win32, Peter Maydell, 2016/03/14