[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 5/5] replay: introduce block devices record/r
From: |
Pavel Dovgalyuk |
Subject: |
Re: [Qemu-devel] [PATCH v4 5/5] replay: introduce block devices record/replay |
Date: |
Mon, 14 Mar 2016 08:52:46 +0300 |
> From: Stefan Hajnoczi [mailto:address@hidden
> On Thu, Mar 10, 2016 at 02:56:20PM +0300, Pavel Dovgalyuk wrote:
> > @@ -135,7 +138,7 @@ void replay_add_event(ReplayAsyncEventKind event_kind,
> >
> > void replay_bh_schedule_event(QEMUBH *bh)
> > {
> > - if (replay_mode != REPLAY_MODE_NONE) {
> > + if (replay_mode != REPLAY_MODE_NONE && events_enabled) {
> > uint64_t id = replay_get_current_step();
> > replay_add_event(REPLAY_ASYNC_EVENT_BH, bh, NULL, id);
> > } else {
>
> Is this hunk a fix that should be in a separate patch or squashed into a
> previous patch?
Right, this is a fix of a separate bug. It manifests itself only
with this block patch, but I can separate it for clearness.
Pavel Dovgalyuk