[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port
From: |
Christophe Fergeau |
Subject: |
[Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port |
Date: |
Mon, 14 Mar 2016 12:41:12 +0100 |
Currently, virgl support has to go through a local unix socket, trying
to connect to a VM using -spice gl through spice://localhost:5900 will
only result in a black screen.
This commit errors out when the user tries to start a VM with both GL
support and a port/tls-port set.
This would fit better in spice-server, but currently QEMU does not call
into spice-server when parsing 'gl' on its command line, so we have to
do this check in QEMU instead.
Signed-off-by: Christophe Fergeau <address@hidden>
---
ui/spice-core.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 7987a4e..94f3236 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -844,6 +844,10 @@ void qemu_spice_init(void)
#ifdef HAVE_SPICE_GL
if (qemu_opt_get_bool(opts, "gl", 0)) {
+ if ((port != 0) || (tls_port != 0)) {
+ error_report("SPICE GL support is local-only for now and
incompatible with -spice port/tls-port");
+ exit(1);
+ }
if (egl_rendernode_init() == 0) {
display_opengl = 1;
}
--
2.5.0
- [Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port,
Christophe Fergeau <=
Re: [Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port, Eric Blake, 2016/03/14
Re: [Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port, Gerd Hoffmann, 2016/03/18