Re: [Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port

[Marc-André Lureau]

On Mon, Mar 14, 2016 at 12:41 PM, Christophe Fergeau
<address@hidden> wrote:
> Currently, virgl support has to go through a local unix socket, trying
> to connect to a VM using -spice gl through spice://localhost:5900 will
> only result in a black screen.
> This commit errors out when the user tries to start a VM with both GL
> support and a port/tls-port set.
> This would fit better in spice-server, but currently QEMU does not call
> into spice-server when parsing 'gl' on its command line, so we have to
> do this check in QEMU instead.
>
> Signed-off-by: Christophe Fergeau <address@hidden>

Reviewed-by: Marc-André Lureau <address@hidden>


> ---
>  ui/spice-core.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/ui/spice-core.c b/ui/spice-core.c
> index 7987a4e..94f3236 100644
> --- a/ui/spice-core.c
> +++ b/ui/spice-core.c
> @@ -844,6 +844,10 @@ void qemu_spice_init(void)
>
>  #ifdef HAVE_SPICE_GL
>      if (qemu_opt_get_bool(opts, "gl", 0)) {
> +        if ((port != 0) || (tls_port != 0)) {
> +            error_report("SPICE GL support is local-only for now and 
> incompatible with -spice port/tls-port");
> +            exit(1);
> +        }
>          if (egl_rendernode_init() == 0) {
>              display_opengl = 1;
>          }
> --
> 2.5.0
>



-- 
Marc-André Lureau