Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/

[Gerd Hoffmann]

On Di, 2016-03-15 at 16:54 +0200, Michael S. Tsirkin wrote:
> On Tue, Mar 15, 2016 at 03:46:35PM +0100, Gerd Hoffmann wrote:
> >   Hi,
> > 
> > > > I think we have already gone through this discussion.
> > > 
> > > So now Corey basically is prevented from sorting sanely
> > > because command line might not start with opt/
> > 
> > Hmm?  There are no guarantees whatsoever if the user used the command
> > line for entries outside /opt.
> > 
> > Beside that the "sort everything lexical for 2.6+" approach will work
> > fine.  I think it is more robust and I suspect we will have less hassle
> > with it long-term.
> > 
> > cheers,
> >   Gerd
> 
> OK so use built-in order with fallback on lexical,

I would just call smbios init from the old location for old machine
types instead of adding code for the built-in sort order ...

cheers,
  Gerd