[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/ |
Date: |
Tue, 15 Mar 2016 15:14:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 15/03/2016 14:55, Michael S. Tsirkin wrote:
> Allowing arbitary file names on command line is setting us up for
> failure: future guests will look for a specific QEMU-specified name and
> will get confused finding a user file there.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
Too bad for the user.
I think we have already gone through this discussion.
Paolo
> ---
> vl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/vl.c b/vl.c
> index 7a28982..5654af6 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2321,6 +2321,7 @@ static int parse_fw_cfg(void *opaque, QemuOpts *opts,
> Error **errp)
> if (strncmp(name, "opt/", 4) != 0) {
> - error_report("warning: externally provided fw_cfg item names "
> - "should be prefixed with \"opt/\"");
> + error_report("externally provided fw_cfg item names "
> + "must be prefixed with \"opt/\"");
> + return -1;
> }
> if (nonempty_str(str)) {
> size = strlen(str); /* NUL terminator NOT included in fw_cfg blob */
>