[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers |
Date: |
Tue, 15 Mar 2016 18:25:25 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 15/03/2016 17:31, Markus Armbruster wrote:
> Paolo Bonzini <address@hidden> writes:
>
>> On 15/03/2016 16:03, Markus Armbruster wrote:
>>> diff --git a/include/hw/hw.h b/include/hw/hw.h
>>> index 2cb69d5..151d65e 100644
>>> --- a/include/hw/hw.h
>>> +++ b/include/hw/hw.h
>>> @@ -15,6 +15,7 @@
>>> #include "qemu/module.h"
>>>
>>> #ifdef NEED_CPU_H
>>> +#include "cpu.h"
>>> #if TARGET_LONG_BITS == 64
>>> #define qemu_put_betl qemu_put_be64
>>> #define qemu_get_betl qemu_get_be64
>>
>> This actually makes things somewhat worse. This dependency of hw/hw.h
>> on NEED_CPU_H should go away altogether.
>>
>> Would it be okay to stick to patches 1-13 for now?
>
> Yes, as long as "for now" approximately means "until 2.7 opens up".
>
> Proposed plan: I pursue 01-13 now, you rebase your need-cpu-h branch
> onto this work when it's ready, I rebase 14-15 onto yours, and carry on.
> Makes sense?
Yes, totally. I've already started rebasing and there's nothing else
that sticks out.
Since I have your attention, what about getting rid of fprintf-fn.h and
moving it into qemu/osdep.h?
Paolo
- Re: [Qemu-devel] [PATCH 13/15] include/crypto: Include qapi-types.h instead of qemu-common.h, (continued)
- [Qemu-devel] [PATCH 11/15] Move ParallelIOArg from qemu-common.h to sysemu/char.h, Markus Armbruster, 2016/03/15
- [Qemu-devel] [PATCH 07/15] include/hw/hw.h: Don't include qemu-common.h, Markus Armbruster, 2016/03/15
- [Qemu-devel] [PATCH 12/15] isa: Move DMA_transfer_handler from qemu-common.h to hw/isa/isa.h, Markus Armbruster, 2016/03/15
- [Qemu-devel] [PATCH 08/15] hw/pci/pci.h: Don't include qemu-common.h, Markus Armbruster, 2016/03/15
- [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers, Markus Armbruster, 2016/03/15
[Qemu-devel] [PATCH 15/15] Drop superfluous qemu-common.h inclusions, Markus Armbruster, 2016/03/15
[Qemu-devel] [PATCH 01/15] include/qemu/osdep.h: Don't include qapi/error.h, Markus Armbruster, 2016/03/15
Re: [Qemu-devel] [PATCH 00/15] Clean up around osdep.h and qemu-common.h, Paolo Bonzini, 2016/03/15