[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/15] Clean up around osdep.h and qemu-common.h
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 00/15] Clean up around osdep.h and qemu-common.h |
Date: |
Fri, 18 Mar 2016 09:47:38 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> On 15/03/2016 16:03, Markus Armbruster wrote:
>> This series tackles two issues:
>>
>> * qapi/error.h and therefore qapi-types.h get included into every file
>> via qemu/osdep.h. Touch the QAPI schema, recompile the world. As
>> the QAPI maintainer, I get to touch it regularly, so this is an itch
>> I need to scratch. PATCH 01-04 drop qapi/error.h from qemu/osdep.h.
>> Unfortunately, the number of .o depending on qapi-types.h barely
>> changes, because it gets included by so many other headers. More
>> work is needed here.
>>
>> * qemu-common.h explicitly asks not to be included in headers, but we
>> do it anyway. PATCH 05-15 clean that up. Cuts the number of .o
>> depending on qemu-common.h from ~95% to ~35%.
>>
>> For additional motivation, see the "Our use of #include is
>> undisciplined, and what to do about it" thread.
>
> Patches 1-13 and possibly 15 are great.
Is this an R-by or Acked-by for 01-13?
Could they still be considered for 2.6? Rebasing them eats compile-time
like no tomorrow.
[...]
[Qemu-devel] [PATCH 15/15] Drop superfluous qemu-common.h inclusions, Markus Armbruster, 2016/03/15
[Qemu-devel] [PATCH 01/15] include/qemu/osdep.h: Don't include qapi/error.h, Markus Armbruster, 2016/03/15
Re: [Qemu-devel] [PATCH 00/15] Clean up around osdep.h and qemu-common.h, Paolo Bonzini, 2016/03/15
- Re: [Qemu-devel] [PATCH 00/15] Clean up around osdep.h and qemu-common.h,
Markus Armbruster <=