[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/6] usb: fix unbound stack usage for usb_mtp_add_str
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 3/6] usb: fix unbound stack usage for usb_mtp_add_str |
Date: |
Mon, 21 Mar 2016 12:10:21 +0100 |
From: Peter Xu <address@hidden>
Use heap instead of stack.
Signed-off-by: Peter Xu <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/usb/dev-mtp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 7391783..62fb7cd 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -718,7 +718,7 @@ static void usb_mtp_add_wstr(MTPData *data, const wchar_t
*str)
static void usb_mtp_add_str(MTPData *data, const char *str)
{
uint32_t len = strlen(str)+1;
- wchar_t wstr[len];
+ wchar_t *wstr = g_new(wchar_t, len);
size_t ret;
ret = mbstowcs(wstr, str, len);
@@ -727,6 +727,8 @@ static void usb_mtp_add_str(MTPData *data, const char *str)
} else {
usb_mtp_add_wstr(data, wstr);
}
+
+ g_free(wstr);
}
static void usb_mtp_add_time(MTPData *data, time_t time)
--
1.8.3.1
- [Qemu-devel] [PULL 0/6] usb patch queue, Gerd Hoffmann, 2016/03/21
- [Qemu-devel] [PULL 3/6] usb: fix unbound stack usage for usb_mtp_add_str,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 4/6] usb: fix unbound stack warning for inotify_watchfn, Gerd Hoffmann, 2016/03/21
- [Qemu-devel] [PULL 5/6] hw/usb/dev-mtp: Guard inotify usage with CONFIG_INOTIFY1, Gerd Hoffmann, 2016/03/21
- [Qemu-devel] [PULL 1/6] usb: Fix compilation for Windows, Gerd Hoffmann, 2016/03/21
- [Qemu-devel] [PULL 6/6] usb: ehci: add capability mmio write function, Gerd Hoffmann, 2016/03/21
- [Qemu-devel] [PULL 2/6] usb: fix unbounded stack warning for xhci_dma_write_u32s, Gerd Hoffmann, 2016/03/21
- Re: [Qemu-devel] [PULL 0/6] usb patch queue, Peter Maydell, 2016/03/22