[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/6] usb: fix unbound stack warning for inotify_watch
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 4/6] usb: fix unbound stack warning for inotify_watchfn |
Date: |
Mon, 21 Mar 2016 12:10:22 +0100 |
From: Peter Xu <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/usb/dev-mtp.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 62fb7cd..01c5e51 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -433,12 +433,11 @@ static void inotify_watchfn(void *arg)
MTPState *s = arg;
ssize_t bytes;
/* From the man page: atleast one event can be read */
- int len = sizeof(struct inotify_event) + NAME_MAX + 1;
int pos;
- char buf[len];
+ char buf[sizeof(struct inotify_event) + NAME_MAX + 1];
for (;;) {
- bytes = read(s->inotifyfd, buf, len);
+ bytes = read(s->inotifyfd, buf, sizeof(buf));
pos = 0;
if (bytes <= 0) {
--
1.8.3.1
- [Qemu-devel] [PULL 0/6] usb patch queue, Gerd Hoffmann, 2016/03/21
- [Qemu-devel] [PULL 3/6] usb: fix unbound stack usage for usb_mtp_add_str, Gerd Hoffmann, 2016/03/21
- [Qemu-devel] [PULL 4/6] usb: fix unbound stack warning for inotify_watchfn,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 5/6] hw/usb/dev-mtp: Guard inotify usage with CONFIG_INOTIFY1, Gerd Hoffmann, 2016/03/21
- [Qemu-devel] [PULL 1/6] usb: Fix compilation for Windows, Gerd Hoffmann, 2016/03/21
- [Qemu-devel] [PULL 6/6] usb: ehci: add capability mmio write function, Gerd Hoffmann, 2016/03/21
- [Qemu-devel] [PULL 2/6] usb: fix unbounded stack warning for xhci_dma_write_u32s, Gerd Hoffmann, 2016/03/21
- Re: [Qemu-devel] [PULL 0/6] usb patch queue, Peter Maydell, 2016/03/22