[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/7] block: Don't disable I/O throttling on sync req
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 1/7] block: Don't disable I/O throttling on sync requests |
Date: |
Thu, 24 Mar 2016 17:39:20 +0100 |
From: Kevin Wolf <address@hidden>
We had to disable I/O throttling with synchronous requests because we
didn't use to run timers in nested event loops when the code was
introduced. This isn't true any more, and throttling works just fine
even when using the synchronous API.
The removed code is in fact dead code since commit a8823a3b ('block: Use
blk_co_pwritev() for blk_write()') because I/O throttling can only be
set on the top layer, but BlockBackend always uses the coroutine
interface now instead of using the sync API emulation in block.c.
Signed-off-by: Kevin Wolf <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
block/io.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/block/io.c b/block/io.c
index 41d954ca..cbba269 100644
--- a/block/io.c
+++ b/block/io.c
@@ -561,17 +561,6 @@ static int bdrv_prwv_co(BlockDriverState *bs, int64_t
offset,
.flags = flags,
};
- /**
- * In sync call context, when the vcpu is blocked, this throttling timer
- * will not fire; so the I/O throttling function has to be disabled here
- * if it has been enabled.
- */
- if (bs->io_limits_enabled) {
- fprintf(stderr, "Disabling I/O throttling on '%s' due "
- "to synchronous I/O.\n", bdrv_get_device_name(bs));
- bdrv_io_limits_disable(bs);
- }
-
if (qemu_in_coroutine()) {
/* Fast-path if already in coroutine context */
bdrv_rw_co_entry(&rwco);
--
1.8.3.1
- [Qemu-devel] [PATCH v3 0/7] bdrv_flush_io_queue removal, shared LinuxAioState, Paolo Bonzini, 2016/03/24
- [Qemu-devel] [PATCH 1/7] block: Don't disable I/O throttling on sync requests,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 2/7] block: make bdrv_start_throttled_reqs return void, Paolo Bonzini, 2016/03/24
- [Qemu-devel] [PATCH 4/7] block: introduce bdrv_no_throttling_begin/end, Paolo Bonzini, 2016/03/24
- [Qemu-devel] [PATCH 5/7] block: plug whole tree at once, introduce bdrv_io_unplugged_begin/end, Paolo Bonzini, 2016/03/24
- [Qemu-devel] [PATCH 3/7] block: move restarting of throttled reqs to block/throttle-groups.c, Paolo Bonzini, 2016/03/24
- [Qemu-devel] [PATCH 6/7] linux-aio: make it more type safe, Paolo Bonzini, 2016/03/24