[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 3/7] block: move restarting of thro
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH 3/7] block: move restarting of throttled reqs to block/throttle-groups.c |
Date: |
Tue, 29 Mar 2016 16:14:02 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 24 Mar 2016 05:39:22 PM CET, Paolo Bonzini wrote:
> @@ -335,6 +346,11 @@ void throttle_group_config(BlockDriverState *bs,
> ThrottleConfig *cfg)
> }
> throttle_config(ts, tt, cfg);
> qemu_mutex_unlock(&tg->lock);
> +
> + aio_context_acquire(bdrv_get_aio_context(bs));
> + qemu_co_enter_next(&bs->throttled_reqs[0]);
> + qemu_co_enter_next(&bs->throttled_reqs[1]);
> + aio_context_release(bdrv_get_aio_context(bs));
> }
None of the functions in throttle-groups.c acquire the AioContext
because they all assume that the caller is doing it, so we can do the
same here for consistency.
Berto
- [Qemu-devel] [PATCH v3 0/7] bdrv_flush_io_queue removal, shared LinuxAioState, Paolo Bonzini, 2016/03/24
- [Qemu-devel] [PATCH 1/7] block: Don't disable I/O throttling on sync requests, Paolo Bonzini, 2016/03/24
- [Qemu-devel] [PATCH 2/7] block: make bdrv_start_throttled_reqs return void, Paolo Bonzini, 2016/03/24
- [Qemu-devel] [PATCH 4/7] block: introduce bdrv_no_throttling_begin/end, Paolo Bonzini, 2016/03/24
- [Qemu-devel] [PATCH 5/7] block: plug whole tree at once, introduce bdrv_io_unplugged_begin/end, Paolo Bonzini, 2016/03/24
- [Qemu-devel] [PATCH 3/7] block: move restarting of throttled reqs to block/throttle-groups.c, Paolo Bonzini, 2016/03/24
- Re: [Qemu-devel] [Qemu-block] [PATCH 3/7] block: move restarting of throttled reqs to block/throttle-groups.c,
Alberto Garcia <=
- [Qemu-devel] [PATCH 6/7] linux-aio: make it more type safe, Paolo Bonzini, 2016/03/24
- [Qemu-devel] [PATCH 7/7] linux-aio: share one LinuxAioState within an AioContext, Paolo Bonzini, 2016/03/24
- Re: [Qemu-devel] [PATCH v3 0/7] bdrv_flush_io_queue removal, shared LinuxAioState, Stefan Hajnoczi, 2016/03/30