[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 09/12] block: add trace events for io_uring
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v5 09/12] block: add trace events for io_uring |
Date: |
Tue, 11 Jun 2019 10:47:55 +0100 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On Mon, Jun 10, 2019 at 07:19:02PM +0530, Aarushi Mehta wrote:
> @@ -294,6 +302,7 @@ LuringState *luring_init(Error **errp)
> int rc;
> LuringState *s;
> s = g_malloc0(sizeof(*s));
> + trace_luring_init_state((void *)s, sizeof(*s));
In C conversion to void * is automatic and doesn't need to be done
manually.
> diff --git a/block/trace-events b/block/trace-events
> index eab51497fc..c4564dcd96 100644
> --- a/block/trace-events
> +++ b/block/trace-events
> @@ -60,6 +60,14 @@ qmp_block_stream(void *bs, void *job) "bs %p job %p"
> file_paio_submit(void *acb, void *opaque, int64_t offset, int count, int
> type) "acb %p opaque %p offset %"PRId64" count %d type %d"
> file_copy_file_range(void *bs, int src, int64_t src_off, int dst, int64_t
> dst_off, int64_t bytes, int flags, int64_t ret) "bs %p src_fd %d offset
> %"PRIu64" dst_fd %d offset %"PRIu64" bytes %"PRIu64" flags %d ret %"PRId64
>
> +#io_uring.c
> +luring_init_state(void *s, size_t size) "s %p size %zu"
> +luring_cleanup_state(void) "s freed"
> +disable luring_io_plug(void) "plug"
> +disable luring_io_unplug(int blocked, int plugged, int queued, int inflight)
> "blocked %d plugged %d queued %d inflight %d"
> +disable luring_do_submit(int blocked, int plugged, int queued, int inflight)
> "blocked %d plugged %d queued %d inflight %d"
> +disable luring_do_submit_done(int ret) "submitted to kernel %d"
Why are these disabled? "disable" compiles them out and they won't be
available at runtime. "disable" should probably be dropped here.
Please include the LuringState *s pointer in trace events since there
can be multiple LuringStates at any given time and it should be possible
to correlate trace events.
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH v5 04/12] block/io_uring: implements interfaces for io_uring, (continued)
- [Qemu-devel] [PATCH v5 06/12] util/async: add aio interfaces for io_uring, Aarushi Mehta, 2019/06/10
- [Qemu-devel] [PATCH v5 08/12] block/file-posix.c: extend to use io_uring, Aarushi Mehta, 2019/06/10
- [Qemu-devel] [PATCH v5 07/12] blockdev: accept io_uring as option, Aarushi Mehta, 2019/06/10
- [Qemu-devel] [PATCH v5 09/12] block: add trace events for io_uring, Aarushi Mehta, 2019/06/10
- [Qemu-devel] [PATCH v5 10/12] block/io_uring: adds userspace completion polling, Aarushi Mehta, 2019/06/10
- [Qemu-devel] [PATCH v5 11/12] qemu-io: adds support for io_uring, Aarushi Mehta, 2019/06/10
- [Qemu-devel] [PATCH v5 12/12] qemu-iotests/087: checks for io_uring, Aarushi Mehta, 2019/06/10