[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] docs/specs/index.rst: Fix minor syntax issu
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] docs/specs/index.rst: Fix minor syntax issues |
Date: |
Tue, 11 Jun 2019 10:51:05 +0100 |
On Mon, 10 Jun 2019 at 22:41, Aleksandar Markovic
<address@hidden> wrote:
>
>
> On Jun 10, 2019 5:25 PM, "Peter Maydell" <address@hidden> wrote:
> >
> > The docs/specs/index.rst has a couple of minor issues which
> > we didn't notice because we weren't building the manual:
> > * the ToC entry for the new PPC XIVE docs points to
> > a nonexistent file
> > * the initial comment needs to be marked by '..', not '.',
> > or it will appear in the output
> > * the title doesn't match the capitialization used by
> > the existing interop or devel manuals, and uses
> > 'full-system emulation' rather than the 'system emulation'
> > that the interop manual title uses
> >
> > Fix these minor issues before we start trying to build the manual.
> >
> > Signed-off-by: Peter Maydell <address@hidden>
> > ---
>
> Acked-by: Aleksandar Markovic <address@hidden>
Hi Aleksandar; I'm just wondering what you were meaning
with this acked-by tag. Generally acked-by means (to me,
and I think usually with qemu) "this patch touches an
area that I maintain, I haven't reviewed it but I'm OK with
it". But this series isn't mips-related, so maybe you
meant reviewed-by instead ?
(Acked-by is a bit of an odd tag because it's less
clear what it means than reviewed-by or signed-off-by,
so it's not very surprising if you've picked up a
different opinion on what it's for.)
thanks
-- PMM
[Qemu-devel] [PATCH 2/2] docs: Build and install specs manual, Peter Maydell, 2019/06/10