[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 15/50] tcg: add MO_HADDR to TCGMemOp
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v3 15/50] tcg: add MO_HADDR to TCGMemOp |
Date: |
Mon, 17 Jun 2019 13:43:19 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 6/14/19 10:11 AM, Alex Bennée wrote:
> + /*
> + * SoftMMU-only: if set, the TCG backend puts the corresponding host
> address
> + * in CPUArchState.hostaddr.
> + */
> + MO_HSHIFT = MO_ASHIFT + 3,
> + MO_HADDR = 1 << MO_HSHIFT,
FYI, Alex and I talked about recomputing the host address within the helper.
For at least a few of the hosts, we currently never compute the full host
address into a single register -- we use reg+reg addressing when possible.
It's only a couple of instructions to re-compute, given that we know that the
tlb lookup succeeded, and importantly they are all out of line and not bloating
the inline code further.
r~
- [Qemu-devel] [PATCH v3 39/50] vl: support -plugin option, (continued)
- [Qemu-devel] [PATCH v3 39/50] vl: support -plugin option, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 38/50] plugin: add API symbols to qemu-plugins.symbols, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 47/50] accel/stubs: reduce headers from tcg-stub, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 30/50] target/hppa: fetch code with translator_ld, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 19/50] tcg: let plugins instrument memory accesses, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 15/50] tcg: add MO_HADDR to TCGMemOp, Alex Bennée, 2019/06/14
- Re: [Qemu-devel] [PATCH v3 15/50] tcg: add MO_HADDR to TCGMemOp,
Richard Henderson <=
- [Qemu-devel] [PATCH v3 37/50] translator: inject instrumentation from plugins, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 13/50] plugin-gen: add module for TCG-related code, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 25/50] translator: add translator_ld{ub, sw, uw, l, q}, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 48/50] include/exec: wrap cpu_ldst.h in CONFIG_TCG, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 50/50] TODO: API changes to make?, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 31/50] target/m68k: fetch code with translator_ld, Alex Bennée, 2019/06/14