[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 37/50] translator: inject instrumentation fro
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v3 37/50] translator: inject instrumentation from plugins |
Date: |
Mon, 17 Jun 2019 15:44:04 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 6/14/19 10:11 AM, Alex Bennée wrote:
> @@ -95,6 +103,10 @@ void translator_loop(const TranslatorOps *ops,
> DisasContextBase *db,
> ops->translate_insn(db, cpu);
> }
>
> + if (plugin_enabled) {
> + plugin_gen_insn_end();
> + }
> +
> /* Stop translation if translate_insn so indicated. */
> if (db->is_jmp != DISAS_NEXT) {
This will of course not be reachable if db->is_jmp == DISAS_NORETURN.
Do we want to not bother calling the plugin for this case?
r~
- [Qemu-devel] [PATCH v3 38/50] plugin: add API symbols to qemu-plugins.symbols, (continued)
- [Qemu-devel] [PATCH v3 38/50] plugin: add API symbols to qemu-plugins.symbols, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 47/50] accel/stubs: reduce headers from tcg-stub, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 30/50] target/hppa: fetch code with translator_ld, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 19/50] tcg: let plugins instrument memory accesses, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 15/50] tcg: add MO_HADDR to TCGMemOp, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 37/50] translator: inject instrumentation from plugins, Alex Bennée, 2019/06/14
- Re: [Qemu-devel] [PATCH v3 37/50] translator: inject instrumentation from plugins,
Richard Henderson <=
- [Qemu-devel] [PATCH v3 13/50] plugin-gen: add module for TCG-related code, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 25/50] translator: add translator_ld{ub, sw, uw, l, q}, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 48/50] include/exec: wrap cpu_ldst.h in CONFIG_TCG, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 50/50] TODO: API changes to make?, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 31/50] target/m68k: fetch code with translator_ld, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 27/50] target/ppc: fetch code with translator_ld, Alex Bennée, 2019/06/14