[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 17/50] atomic_template: add inline trace/plug
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v3 17/50] atomic_template: add inline trace/plugin helpers |
Date: |
Mon, 17 Jun 2019 13:47:30 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 6/14/19 10:11 AM, Alex Bennée wrote:
> +#ifndef ATOMIC_TEMPLATE_COMMON
> +#define ATOMIC_TEMPLATE_COMMON
> +static inline
> +void atomic_trace_rmw_pre(CPUArchState *env, target_ulong addr, uint8_t info)
> +{
> + CPUState *cpu = env_cpu(env);
> +
> + trace_guest_mem_before_exec(cpu, addr, info);
> + trace_guest_mem_before_exec(cpu, addr, info | TRACE_MEM_ST);
> +}
> +
> +static inline void atomic_trace_rmw_post(CPUArchState *env, target_ulong
> addr,
> + void *haddr, uint8_t info)
> +{
> +}
> +
> +static inline
> +void atomic_trace_ld_pre(CPUArchState *env, target_ulong addr, uint8_t info)
> +{
> + trace_guest_mem_before_exec(env_cpu(env), addr, info);
> +}
> +
> +static inline void atomic_trace_ld_post(CPUArchState *env, target_ulong addr,
> + void *haddr, uint8_t info)
> +{
> +}
> +
> +static inline
> +void atomic_trace_st_pre(CPUArchState *env, target_ulong addr, uint8_t info)
> +{
> + trace_guest_mem_before_exec(env_cpu(env), addr, info);
> +}
> +
> +static inline void atomic_trace_st_post(CPUArchState *env, target_ulong addr,
> + void *haddr, uint8_t info)
> +{
> +}
> +#endif /* ATOMIC_TEMPLATE_COMMON */
>
All of this should just go into atomic_common.inc.c.
r~
- [Qemu-devel] [PATCH v3 44/50] plugin: add qemu_plugin_insn_disas helper, (continued)
- [Qemu-devel] [PATCH v3 44/50] plugin: add qemu_plugin_insn_disas helper, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 18/50] cpu_ldst_useronly_template: remove redundant #ifndef CODE_ACCESS, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 20/50] translate-all: notify plugin code of tb_flush, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 46/50] tests/plugin: add hotpages plugin to breakdown memory access patterns, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 33/50] target/riscv: fetch code with translator_ld, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 42/50] tests/tcg: enable plugin testing, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 17/50] atomic_template: add inline trace/plugin helpers, Alex Bennée, 2019/06/14
- Re: [Qemu-devel] [PATCH v3 17/50] atomic_template: add inline trace/plugin helpers,
Richard Henderson <=
- [Qemu-devel] [PATCH v3 40/50] linux-user: support -plugin option, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 32/50] target/alpha: fetch code with translator_ld, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 24/50] plugin-gen: add plugin_insn_append, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 29/50] target/i386: fetch code with translator_ld, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 26/50] target/arm: call qemu_plugin_insn_append, Alex Bennée, 2019/06/14