[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 33/50] target/riscv: fetch code with translat
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v3 33/50] target/riscv: fetch code with translator_ld |
Date: |
Mon, 17 Jun 2019 15:38:45 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 6/14/19 10:11 AM, Alex Bennée wrote:
> +++ b/target/riscv/translate.c
> @@ -793,7 +793,7 @@ static void riscv_tr_translate_insn(DisasContextBase
> *dcbase, CPUState *cpu)
> DisasContext *ctx = container_of(dcbase, DisasContext, base);
> CPURISCVState *env = cpu->env_ptr;
>
> - ctx->opcode = cpu_ldl_code(env, ctx->base.pc_next);
> + ctx->opcode = translator_ldl(env, ctx->base.pc_next);
I'll note for the riscv folks that this is an existing bug, reading too much in
the case of an RVC instruction. This could well matter for the last 2-byte
instruction at the end of a page.
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [Qemu-devel] [PATCH v3 23/50] cpu: hook plugin vcpu events, (continued)
- [Qemu-devel] [PATCH v3 11/50] cputlb: document get_page_addr_code, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 44/50] plugin: add qemu_plugin_insn_disas helper, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 18/50] cpu_ldst_useronly_template: remove redundant #ifndef CODE_ACCESS, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 20/50] translate-all: notify plugin code of tb_flush, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 46/50] tests/plugin: add hotpages plugin to breakdown memory access patterns, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 33/50] target/riscv: fetch code with translator_ld, Alex Bennée, 2019/06/14
- Re: [Qemu-devel] [PATCH v3 33/50] target/riscv: fetch code with translator_ld,
Richard Henderson <=
- [Qemu-devel] [PATCH v3 42/50] tests/tcg: enable plugin testing, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 17/50] atomic_template: add inline trace/plugin helpers, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 40/50] linux-user: support -plugin option, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 32/50] target/alpha: fetch code with translator_ld, Alex Bennée, 2019/06/14
- [Qemu-devel] [PATCH v3 24/50] plugin-gen: add plugin_insn_append, Alex Bennée, 2019/06/14