[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] target/arm: NS BusFault on vector table fet
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 1/6] target/arm: NS BusFault on vector table fetch escalates to NS HardFault |
Date: |
Tue, 18 Jun 2019 11:31:05 +0100 |
On Mon, 17 Jun 2019 at 20:28, Richard Henderson
<address@hidden> wrote:
>
> On 6/17/19 10:53 AM, Peter Maydell wrote:
> > + * The HardFault is Secure if BFHFNMINS is 0 (meaning that all HFs are
> > + * secure); otherwise it targets the same security state as the
> > + * underlying exception.
> > */
> > - exc_secure = targets_secure ||
> > - !(cpu->env.v7m.aircr & R_V7M_AIRCR_BFHFNMINS_MASK);
> > + if (!(cpu->env.v7m.aircr & R_V7M_AIRCR_BFHFNMINS_MASK)) {
> > + exc_secure = false;
> > + }
>
> exc_secure = true, surely?
Yep, good catch. I got it right in the comment text :-)
thanks
-- PMM
- [Qemu-devel] [PATCH 0/6] Six minor M-profile bugfixes, Peter Maydell, 2019/06/17
- [Qemu-devel] [PATCH 3/6] target/arm: v8M: Check state of exception being returned from, Peter Maydell, 2019/06/17
- [Qemu-devel] [PATCH 2/6] arm v8M: Forcibly clear negative-priority exceptions on deactivate, Peter Maydell, 2019/06/17
- [Qemu-devel] [PATCH 1/6] target/arm: NS BusFault on vector table fetch escalates to NS HardFault, Peter Maydell, 2019/06/17
- [Qemu-devel] [PATCH 6/6] target/arm: Execute Thumb instructions when their condbits are 0xf, Peter Maydell, 2019/06/17
- [Qemu-devel] [PATCH 5/6] hw/timer/armv7m_systick: Forbid non-privileged accesses, Peter Maydell, 2019/06/17
- [Qemu-devel] [PATCH 4/6] target/arm: Use _ra versions of cpu_stl_data() in v7M helpers, Peter Maydell, 2019/06/17