Re: [Qemu-devel] [PULL 16/16] vl: Deprecate -mon pretty=... for HMP monitors

[Kevin Wolf]

Am 18.06.2019 um 11:01 hat Daniel P. Berrangé geschrieben:
> On Mon, Jun 17, 2019 at 08:49:03PM +0200, Markus Armbruster wrote:
> > From: Kevin Wolf <address@hidden>
> > 
> > The -mon pretty=on|off switch of the -mon option applies only to QMP
> > monitors. It's silently ignored for HMP. Deprecate this combination so
> > that we can make it an error in future versions.
> 
> No objection to merging this PR as is, but how about we extend the
> deprecation to QMP too ?
> 
> I was responsible for adding this option back in 2010 and I don't
> think I've used it since 2012 when I added pretty printing support
> to scripts/qmp/qmp-shell. I struggle to imagine good reasons for
> using QMP directly with pretty printing, as opposed to doing it
> via qmp-shell or another wrapper tool.

qemu-iotests uses it. It doesn't only make the output (and espeically
diffs on failure) much more readable, but in fact also avoids very long
lines in the refernce output that used to break patch emails when we
didn't use pretty printing yet.

So let's keep it for QMP, please.

Kevin