[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] pcie: don't skip multi-mask events
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] pcie: don't skip multi-mask events |
Date: |
Mon, 1 Jul 2019 11:56:57 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 6/21/19 8:46 AM, Michael S. Tsirkin wrote:
> If we are trying to set multiple bits at once, testing that just one of
> them is already set gives a false positive. As a result we won't
> interrupt guest if e.g. presence detection change and attention button
> press are both set. This happens with multi-function device removal.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/pci/pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
> index 88c30ff74c..b22527000d 100644
> --- a/hw/pci/pcie.c
> +++ b/hw/pci/pcie.c
> @@ -383,7 +383,7 @@ static void pcie_cap_slot_event(PCIDevice *dev,
> PCIExpressHotPlugEvent event)
> {
> /* Minor optimization: if nothing changed - no event is needed. */
> if (pci_word_test_and_set_mask(dev->config + dev->exp.exp_cap +
> - PCI_EXP_SLTSTA, event)) {
> + PCI_EXP_SLTSTA, event) == event) {
> return;
> }
> hotplug_event_notify(dev);
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>