[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/3] net: tap: restrict bridge name to IFNAMS
From: |
P J P |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/3] net: tap: restrict bridge name to IFNAMSIZ |
Date: |
Mon, 1 Jul 2019 15:27:15 +0530 (IST) |
+-- On Mon, 1 Jul 2019, Daniel P. Berrangé wrote --+
| Playing games with multiple "perfectly" sized static buffers & snprintf is
| madness. How about re-writing this method so that it just uses
| g_strdup_printf() to dynamically format the helper_cmd string.
|
| Alternatively we could get rid of the use of shell and directly exec the
| helper program. This would let us just pass argv[] and avoid the printf'ing
| entirely.
Okay, makes sense; I'll prepare patch v3.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
- [Qemu-devel] [PATCH v2 0/3] restrict bridge interface name to IFNAMSIZ, P J P, 2019/07/01
- [Qemu-devel] [PATCH v2 1/3] qemu-bridge-helper: restrict interface name to IFNAMSIZ, P J P, 2019/07/01
- [Qemu-devel] [PATCH v2 3/3] net: tap: restrict bridge name to IFNAMSIZ, P J P, 2019/07/01
- [Qemu-devel] [PATCH v2 2/3] qemu-bridge-helper: move repeating code in parse_acl_file, P J P, 2019/07/01
- Re: [Qemu-devel] [PATCH v2 0/3] restrict bridge interface name to IFNAMSIZ, no-reply, 2019/07/01
- Re: [Qemu-devel] [PATCH v2 0/3] restrict bridge interface name to IFNAMSIZ, no-reply, 2019/07/01