[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 15/18] iotests: teach FilePath to produce mul
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v2 15/18] iotests: teach FilePath to produce multiple paths |
Date: |
Thu, 4 Jul 2019 19:50:47 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 03.07.19 23:55, John Snow wrote:
> Use "FilePaths" instead of "FilePath" to request multiple files be
> cleaned up after we leave that object's scope.
>
> This is not crucial; but it saves a little typing.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> tests/qemu-iotests/iotests.py | 33 ++++++++++++++++++++++-----------
> 1 file changed, 22 insertions(+), 11 deletions(-)
>
> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> index c544659ecb..db00fd2adf 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py
[...]
> @@ -391,7 +403,6 @@ def file_path_remover():
> except OSError:
> pass
>
> -
> def file_path(*names):
> ''' Another way to get auto-generated filename that cleans itself up.
>
Not sure about this hunk, but OK.
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 14/18] iotests: teach run_job to cancel pending jobs, (continued)
[Qemu-devel] [PATCH v2 13/18] iotests: add testing shim for script-style python tests, John Snow, 2019/07/03
[Qemu-devel] [PATCH v2 15/18] iotests: teach FilePath to produce multiple paths, John Snow, 2019/07/03
- Re: [Qemu-devel] [PATCH v2 15/18] iotests: teach FilePath to produce multiple paths,
Max Reitz <=
[Qemu-devel] [PATCH v2 16/18] iotests: Add virtio-scsi device helper, John Snow, 2019/07/03
[Qemu-devel] [PATCH v2 18/18] block/backup: loosen restriction on readonly bitmaps, John Snow, 2019/07/03
[Qemu-devel] [PATCH v2 17/18] iotests: add test 257 for bitmap-mode backups, John Snow, 2019/07/03
Re: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode, no-reply, 2019/07/03
Re: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode, no-reply, 2019/07/03
Re: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode, no-reply, 2019/07/04