Re: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
26e6479 block/backup: loosen restriction on readonly bitmaps
755e1b1 iotests: add test 257 for bitmap-mode backups
d48c9ee iotests: Add virtio-scsi device helper
b6e4226 iotests: teach FilePath to produce multiple paths
9b7ddb3 iotests: teach run_job to cancel pending jobs
78ed529 iotests: add testing shim for script-style python tests
78a4fa3 block/backup: add 'always' bitmap sync policy
edcb2f9 block/backup: upgrade copy_bitmap to BdrvDirtyBitmap
5691b3e block/dirty-bitmap: add bdrv_dirty_bitmap_get
3decdf3 block/dirty-bitmap: add bdrv_dirty_bitmap_merge_internal
1ee3ffe hbitmap: enable merging across granularities
0d187e6 hbitmap: Fix merge when b is empty, and result is not an alias of a
9fb7b80 block/backup: add 'never' policy to bitmap sync mode
3025abb block/backup: Add mirror sync mode 'bitmap'
78173da qapi: add BitmapSyncMode enum
8d6effc blockdev-backup: utilize do_backup_common
189a557 drive-backup: create do_backup_common
1aa2202 qapi/block-core: Introduce BackupCommon

=== OUTPUT BEGIN ===
1/18 Checking commit 1aa2202a91cb (qapi/block-core: Introduce BackupCommon)
2/18 Checking commit 189a557d32e9 (drive-backup: create do_backup_common)
3/18 Checking commit 8d6effca544a (blockdev-backup: utilize do_backup_common)
4/18 Checking commit 78173daac67b (qapi: add BitmapSyncMode enum)
5/18 Checking commit 3025abb79847 (block/backup: Add mirror sync mode 'bitmap')
6/18 Checking commit 9fb7b804caa8 (block/backup: add 'never' policy to bitmap 
sync mode)
WARNING: Block comments use a leading /* on a separate line
#26: FILE: block/backup.c:269:
+        /* Failure, or we don't want to synchronize the bitmap.

WARNING: Block comments use a trailing */ on a separate line
#27: FILE: block/backup.c:270:
+         * Merge the successor back into the parent, delete nothing. */

total: 0 errors, 2 warnings, 25 lines checked

Patch 6/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/18 Checking commit 0d187e69012e (hbitmap: Fix merge when b is empty, and 
result is not an alias of a)
8/18 Checking commit 1ee3ffe706d4 (hbitmap: enable merging across granularities)
9/18 Checking commit 3decdf358bb7 (block/dirty-bitmap: add 
bdrv_dirty_bitmap_merge_internal)
10/18 Checking commit 5691b3e06e73 (block/dirty-bitmap: add 
bdrv_dirty_bitmap_get)
ERROR: open brace '{' following function declarations go on the next line
#36: FILE: block/dirty-bitmap.c:517:
+bool bdrv_dirty_bitmap_get(BdrvDirtyBitmap *bitmap, int64_t offset) {

total: 1 errors, 0 warnings, 72 lines checked

Patch 10/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/18 Checking commit edcb2f9d526e (block/backup: upgrade copy_bitmap to 
BdrvDirtyBitmap)
WARNING: line over 80 characters
#60: FILE: block/backup.c:174:
+    bdrv_reset_dirty_bitmap(job->copy_bitmap, start, job->cluster_size * 
nr_clusters);

WARNING: line over 80 characters
#66: FILE: block/backup.c:179:
+        bdrv_set_dirty_bitmap(job->copy_bitmap, start, job->cluster_size * 
nr_clusters);

total: 0 errors, 2 warnings, 192 lines checked

Patch 11/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/18 Checking commit 78a4fa304c33 (block/backup: add 'always' bitmap sync 
policy)
WARNING: Block comments use a leading /* on a separate line
#41: FILE: block/backup.c:273:
+        /* We succeeded, or we always intended to sync the bitmap.

WARNING: Block comments use a trailing */ on a separate line
#42: FILE: block/backup.c:274:
+         * Delete this bitmap and install the child. */

WARNING: Block comments use a leading /* on a separate line
#46: FILE: block/backup.c:277:
+        /* We failed, or we never intended to sync the bitmap anyway.

WARNING: Block comments use a trailing */ on a separate line
#47: FILE: block/backup.c:278:
+         * Merge the successor back into the parent, keeping all data. */

total: 0 errors, 4 warnings, 47 lines checked

Patch 12/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/18 Checking commit 78ed5297c739 (iotests: add testing shim for script-style 
python tests)
14/18 Checking commit 9b7ddb390360 (iotests: teach run_job to cancel pending 
jobs)
15/18 Checking commit b6e42267d4bc (iotests: teach FilePath to produce multiple 
paths)
WARNING: line over 80 characters
#63: FILE: tests/qemu-iotests/iotests.py:392:
+    """FilePath is a specialization of FilePaths that takes a single 
filename."""

total: 0 errors, 1 warnings, 67 lines checked

Patch 15/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/18 Checking commit d48c9ee0bec9 (iotests: Add virtio-scsi device helper)
17/18 Checking commit 755e1b11478c (iotests: add test 257 for bitmap-mode 
backups)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100755

total: 0 errors, 1 warnings, 2612 lines checked

Patch 17/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/18 Checking commit 26e64793fc71 (block/backup: loosen restriction on 
readonly bitmaps)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden