[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode |
Date: |
Thu, 4 Jul 2019 11:58:09 -0700 (PDT) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode
Type: series
Message-id: address@hidden
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
29d2e89 block/backup: loosen restriction on readonly bitmaps
3dac5e8 iotests: add test 257 for bitmap-mode backups
9b334f2 iotests: Add virtio-scsi device helper
76de918 iotests: teach FilePath to produce multiple paths
25e47cf iotests: teach run_job to cancel pending jobs
246979a iotests: add testing shim for script-style python tests
da9f5b2 block/backup: add 'always' bitmap sync policy
a0da4a4 block/backup: upgrade copy_bitmap to BdrvDirtyBitmap
c38beb0 block/dirty-bitmap: add bdrv_dirty_bitmap_get
e1f9101 block/dirty-bitmap: add bdrv_dirty_bitmap_merge_internal
8dcbb6e hbitmap: enable merging across granularities
f0a01f5 hbitmap: Fix merge when b is empty, and result is not an alias of a
cfddaac block/backup: add 'never' policy to bitmap sync mode
3d87c7e block/backup: Add mirror sync mode 'bitmap'
4bfeaea qapi: add BitmapSyncMode enum
aa153cb blockdev-backup: utilize do_backup_common
9b2ea6d drive-backup: create do_backup_common
f1dfe57 qapi/block-core: Introduce BackupCommon
=== OUTPUT BEGIN ===
1/18 Checking commit f1dfe5731cdd (qapi/block-core: Introduce BackupCommon)
2/18 Checking commit 9b2ea6d12ad1 (drive-backup: create do_backup_common)
3/18 Checking commit aa153cbc1d7b (blockdev-backup: utilize do_backup_common)
4/18 Checking commit 4bfeaeaea5c0 (qapi: add BitmapSyncMode enum)
5/18 Checking commit 3d87c7e95994 (block/backup: Add mirror sync mode 'bitmap')
6/18 Checking commit cfddaacb73e3 (block/backup: add 'never' policy to bitmap
sync mode)
WARNING: Block comments use a leading /* on a separate line
#26: FILE: block/backup.c:269:
+ /* Failure, or we don't want to synchronize the bitmap.
WARNING: Block comments use a trailing */ on a separate line
#27: FILE: block/backup.c:270:
+ * Merge the successor back into the parent, delete nothing. */
total: 0 errors, 2 warnings, 25 lines checked
Patch 6/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/18 Checking commit f0a01f558ce5 (hbitmap: Fix merge when b is empty, and
result is not an alias of a)
8/18 Checking commit 8dcbb6e9f205 (hbitmap: enable merging across granularities)
9/18 Checking commit e1f9101828dc (block/dirty-bitmap: add
bdrv_dirty_bitmap_merge_internal)
10/18 Checking commit c38beb034ad8 (block/dirty-bitmap: add
bdrv_dirty_bitmap_get)
ERROR: open brace '{' following function declarations go on the next line
#36: FILE: block/dirty-bitmap.c:517:
+bool bdrv_dirty_bitmap_get(BdrvDirtyBitmap *bitmap, int64_t offset) {
total: 1 errors, 0 warnings, 72 lines checked
Patch 10/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/18 Checking commit a0da4a40d744 (block/backup: upgrade copy_bitmap to
BdrvDirtyBitmap)
WARNING: line over 80 characters
#60: FILE: block/backup.c:174:
+ bdrv_reset_dirty_bitmap(job->copy_bitmap, start, job->cluster_size *
nr_clusters);
WARNING: line over 80 characters
#66: FILE: block/backup.c:179:
+ bdrv_set_dirty_bitmap(job->copy_bitmap, start, job->cluster_size *
nr_clusters);
total: 0 errors, 2 warnings, 192 lines checked
Patch 11/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/18 Checking commit da9f5b248832 (block/backup: add 'always' bitmap sync
policy)
WARNING: Block comments use a leading /* on a separate line
#41: FILE: block/backup.c:273:
+ /* We succeeded, or we always intended to sync the bitmap.
WARNING: Block comments use a trailing */ on a separate line
#42: FILE: block/backup.c:274:
+ * Delete this bitmap and install the child. */
WARNING: Block comments use a leading /* on a separate line
#46: FILE: block/backup.c:277:
+ /* We failed, or we never intended to sync the bitmap anyway.
WARNING: Block comments use a trailing */ on a separate line
#47: FILE: block/backup.c:278:
+ * Merge the successor back into the parent, keeping all data. */
total: 0 errors, 4 warnings, 47 lines checked
Patch 12/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/18 Checking commit 246979a623e7 (iotests: add testing shim for script-style
python tests)
14/18 Checking commit 25e47cf37f92 (iotests: teach run_job to cancel pending
jobs)
15/18 Checking commit 76de9180c629 (iotests: teach FilePath to produce multiple
paths)
WARNING: line over 80 characters
#63: FILE: tests/qemu-iotests/iotests.py:392:
+ """FilePath is a specialization of FilePaths that takes a single
filename."""
total: 0 errors, 1 warnings, 67 lines checked
Patch 15/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/18 Checking commit 9b334f2cf12b (iotests: Add virtio-scsi device helper)
17/18 Checking commit 3dac5e8f8422 (iotests: add test 257 for bitmap-mode
backups)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11:
new file mode 100755
total: 0 errors, 1 warnings, 2612 lines checked
Patch 17/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/18 Checking commit 29d2e8995ec3 (block/backup: loosen restriction on
readonly bitmaps)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH v2 16/18] iotests: Add virtio-scsi device helper, (continued)
- [Qemu-devel] [PATCH v2 16/18] iotests: Add virtio-scsi device helper, John Snow, 2019/07/03
- [Qemu-devel] [PATCH v2 18/18] block/backup: loosen restriction on readonly bitmaps, John Snow, 2019/07/03
- [Qemu-devel] [PATCH v2 17/18] iotests: add test 257 for bitmap-mode backups, John Snow, 2019/07/03
- Re: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode, no-reply, 2019/07/03
- Re: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode, no-reply, 2019/07/03
- Re: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode, no-reply, 2019/07/04
- Re: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode,
no-reply <=