Re: [Qemu-devel] Parallel make build fails on fast machine

[Daniel P . Berrangé]

On Mon, Jul 08, 2019 at 12:17:12PM +0200, Philippe Mathieu-Daudé wrote:
> On 7/8/19 11:41 AM, Daniel P. Berrangé wrote:
> > On Sat, Jul 06, 2019 at 09:35:30PM +0100, Peter Maydell wrote:
> >> On Sat, 6 Jul 2019 at 11:28, Mark Cave-Ayland
> >> <address@hidden> wrote:
> >>>
> >>> On 06/07/2019 11:16, Peter Maydell wrote:
> >>>> If you just do 'make' rather than 'make install' does it fail the same 
> >>>> way?
> >>>
> >>> Interesting. A quick test shows that "make V=1 -j2" works fine, it's just 
> >>> "make V=1
> >>> -j2 install" which is failing.
> >>
> >> Mmm. I suspect most people just do the plain make (with the make install
> >> phase either never or as a second command afterwards), so 
> >> missing-dependency
> >> bugs between the install targets and the build targets are probably more
> >> likely to lurk around. We should stil fix them, though, assuming we
> >> can track them down...
> > 
> > The main 'install' target depends on 'all':
> > 
> > install: all $(if $(BUILD_DOCS),install-doc) install-datadir 
> > install-localstatedir \
> > 
> > 
> > but I think still allows 'install-doc', 'install-datadir' and
> > 'install-localstatedir'  to parallelize wrt 'all'. I guess the fix is to
> > make each of those 'install-xxx' targets depend on 'all' instead.
> 
> I'm not sure I follow, are you suggesting this as a kludge for this
> release, or you recommend this as a default?

I think it is the right solution in general.

> Apparently only 'recurse-install' depends of 'all'.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|