[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v14 04/11] qemu_thread: supplement error handling fo
From: |
Fei Li |
Subject: |
[Qemu-devel] [PATCH v14 04/11] qemu_thread: supplement error handling for pci_edu_realize |
Date: |
Wed, 17 Jul 2019 10:33:03 +0800 |
From: Fei Li <address@hidden>
Utilize the existed errp to propagate the error and do the
corresponding cleanup to replace the temporary &error_abort.
Cc: Markus Armbruster <address@hidden>
Cc: Jiri Slaby <address@hidden>
Signed-off-by: Fei Li <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
---
hw/misc/edu.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/hw/misc/edu.c b/hw/misc/edu.c
index 1edc66955a..632b56f64c 100644
--- a/hw/misc/edu.c
+++ b/hw/misc/edu.c
@@ -371,9 +371,14 @@ static void pci_edu_realize(PCIDevice *pdev, Error **errp)
qemu_mutex_init(&edu->thr_mutex);
qemu_cond_init(&edu->thr_cond);
- /* TODO: let the further caller handle the error instead of abort() here */
- qemu_thread_create(&edu->thread, "edu", edu_fact_thread,
- edu, QEMU_THREAD_JOINABLE, &error_abort);
+ if (qemu_thread_create(&edu->thread, "edu", edu_fact_thread,
+ edu, QEMU_THREAD_JOINABLE, errp) < 0) {
+ qemu_cond_destroy(&edu->thr_cond);
+ qemu_mutex_destroy(&edu->thr_mutex);
+ timer_del(&edu->dma_timer);
+ msi_uninit(pdev);
+ return;
+ }
memory_region_init_io(&edu->mmio, OBJECT(edu), &edu_mmio_ops, edu,
"edu-mmio", 1 * MiB);
--
2.11.0
- [Qemu-devel] [PATCH v14 00/11] qemu_thread_create: propagate the error to callers to handle, Fei Li, 2019/07/16
- [Qemu-devel] [PATCH v14 01/11] qemu_thread: make qemu_thread_create() take Error ** argument, Fei Li, 2019/07/16
- [Qemu-devel] [PATCH v14 03/11] qemu_thread: supplement error handling for qmp_dump_guest_memory, Fei Li, 2019/07/16
- [Qemu-devel] [PATCH v14 02/11] qemu_thread: supplement error handling for qemu_X_start_vcpu, Fei Li, 2019/07/16
- [Qemu-devel] [PATCH v14 04/11] qemu_thread: supplement error handling for pci_edu_realize,
Fei Li <=
- [Qemu-devel] [PATCH v14 05/11] qemu_thread: supplement error handling for h_resize_hpt_prepare, Fei Li, 2019/07/16
- [Qemu-devel] [PATCH v14 06/11] qemu_thread: supplement error handling for emulated_realize, Fei Li, 2019/07/16
- [Qemu-devel] [PATCH v14 07/11] qemu_thread: supplement error handling for iothread_complete, Fei Li, 2019/07/16
- [Qemu-devel] [PATCH v14 08/11] qemu_thread: supplement error handling for qemu_signalfd_compat, Fei Li, 2019/07/16
- [Qemu-devel] [PATCH v14 09/11] qemu_thread: supplement error handling for migration, Fei Li, 2019/07/16
- [Qemu-devel] [PATCH v14 10/11] qemu_thread: supplement error handling for vnc_start_worker_thread, Fei Li, 2019/07/16
- [Qemu-devel] [PATCH v14 11/11] qemu_thread: supplement error handling for touch_all_pages, Fei Li, 2019/07/16