[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v14 08/11] qemu_thread: supplement error handling fo
From: |
Fei Li |
Subject: |
[Qemu-devel] [PATCH v14 08/11] qemu_thread: supplement error handling for qemu_signalfd_compat |
Date: |
Wed, 17 Jul 2019 10:33:07 +0800 |
Set errno, do some cleanup, and return -1 to replace the temporary
&error_abort when failing to create sigwait_compat.
Cc: Markus Armbruster <address@hidden>
Cc: Eric Blake <address@hidden>
Signed-off-by: Fei Li <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
---
util/compatfd.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/util/compatfd.c b/util/compatfd.c
index caad10ae56..bd15464586 100644
--- a/util/compatfd.c
+++ b/util/compatfd.c
@@ -70,6 +70,7 @@ static int qemu_signalfd_compat(const sigset_t *mask)
struct sigfd_compat_info *info;
QemuThread thread;
int fds[2];
+ int ret;
info = malloc(sizeof(*info));
if (info == NULL) {
@@ -88,9 +89,15 @@ static int qemu_signalfd_compat(const sigset_t *mask)
memcpy(&info->mask, mask, sizeof(*mask));
info->fd = fds[1];
- /* TODO: let the further caller handle the error instead of abort() here */
- qemu_thread_create(&thread, "signalfd_compat", sigwait_compat,
- info, QEMU_THREAD_DETACHED, &error_abort);
+ ret = qemu_thread_create(&thread, "signalfd_compat", sigwait_compat,
+ info, QEMU_THREAD_DETACHED, NULL);
+ if (ret < 0) {
+ close(fds[0]);
+ close(fds[1]);
+ free(info);
+ errno = -ret;
+ return -1;
+ }
return fds[0];
}
--
2.11.0
- [Qemu-devel] [PATCH v14 00/11] qemu_thread_create: propagate the error to callers to handle, Fei Li, 2019/07/16
- [Qemu-devel] [PATCH v14 01/11] qemu_thread: make qemu_thread_create() take Error ** argument, Fei Li, 2019/07/16
- [Qemu-devel] [PATCH v14 03/11] qemu_thread: supplement error handling for qmp_dump_guest_memory, Fei Li, 2019/07/16
- [Qemu-devel] [PATCH v14 02/11] qemu_thread: supplement error handling for qemu_X_start_vcpu, Fei Li, 2019/07/16
- [Qemu-devel] [PATCH v14 04/11] qemu_thread: supplement error handling for pci_edu_realize, Fei Li, 2019/07/16
- [Qemu-devel] [PATCH v14 05/11] qemu_thread: supplement error handling for h_resize_hpt_prepare, Fei Li, 2019/07/16
- [Qemu-devel] [PATCH v14 06/11] qemu_thread: supplement error handling for emulated_realize, Fei Li, 2019/07/16
- [Qemu-devel] [PATCH v14 07/11] qemu_thread: supplement error handling for iothread_complete, Fei Li, 2019/07/16
- [Qemu-devel] [PATCH v14 08/11] qemu_thread: supplement error handling for qemu_signalfd_compat,
Fei Li <=
- [Qemu-devel] [PATCH v14 09/11] qemu_thread: supplement error handling for migration, Fei Li, 2019/07/16
- [Qemu-devel] [PATCH v14 10/11] qemu_thread: supplement error handling for vnc_start_worker_thread, Fei Li, 2019/07/16
- [Qemu-devel] [PATCH v14 11/11] qemu_thread: supplement error handling for touch_all_pages, Fei Li, 2019/07/16