[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] Revert "Revert "globals: Allow global pr
|
From: |
Cornelia Huck |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] Revert "Revert "globals: Allow global properties to be optional"" |
|
Date: |
Mon, 29 Jul 2019 18:46:04 +0200 |
On Mon, 29 Jul 2019 17:29:02 +0100
"Dr. David Alan Gilbert (git)" <address@hidden> wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> This reverts commit 8fa70dbd8bb478d9483c1da3e9976a2d86b3f9a0.
>
> Because we're about to revert it's neighbour and thus uses an optional
> again.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---
> include/hw/qdev-core.h | 3 +++
> qom/object.c | 3 +++
> 2 files changed, 6 insertions(+)
As discussed on IRC, the 'bugs' mentioned in that commit were related
to the other patch that is being reverted; so I don't really mind it
for 4.1 (IOW, either of the two revert approaches should be fine.)
Reviewed-by: Cornelia Huck <address@hidden>