Re: [Qemu-devel] [PATCH 0/4] backup: fix skipping unallocated clusters

[Vladimir Sementsov-Ogievskiy]

14 авг. 2019 г. 17:43 пользователь Vladimir Sementsov-Ogievskiy 
<address@hidden> написал:

Hi all!

There is a bug in not yet merged patch
"block/backup: teach TOP to never copy unallocated regions"
in https://github.com/jnsnow/qemu bitmaps. 04 fixes it. So, I propose
to put 01-03 somewhere before
"block/backup: teach TOP to never copy unallocated regions"
and squash 04 into "block/backup: teach TOP to never copy unallocated regions"

Hmm, don't bother with it. Simpler is fix the bug in your commit by just use 
skip_bytes variable when initializing dirty_end.


Based-on: https://github.com/jnsnow/qemu bitmaps

Vladimir Sementsov-Ogievskiy (4):
  block/dirty-bitmap: switch _next_dirty_area and _next_zero to int64_t
  block/dirty-bitmap: add _next_dirty API
  block/backup: use bdrv_dirty_bitmap_next_dirty
  block/backup: fix and improve skipping unallocated in backup_do_cow

include/block/dirty-bitmap.h |  8 ++--
include/qemu/hbitmap.h       | 18 +++++++--
block/backup.c               | 33 ++++++++++-------
block/dirty-bitmap.c         | 12 ++++--
block/mirror.c               |  4 +-
tests/test-hbitmap.c         | 32 ++++++++--------
util/hbitmap.c               | 72 ++++++++++++++++++++----------------
block/trace-events           |  1 -
8 files changed, 107 insertions(+), 73 deletions(-)

--
2.18.0