[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] backup: fix skipping unallocated clusters
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] backup: fix skipping unallocated clusters |
Date: |
Tue, 20 Aug 2019 08:28:09 +0000 |
16.08.2019 22:11, John Snow wrote:
>
>
> On 8/14/19 12:54 PM, Vladimir Sementsov-Ogievskiy wrote:
>>
>>
>> 14 авг. 2019 г. 17:43 пользователь Vladimir Sementsov-Ogievskiy
>> <address@hidden> написал:
>>
>> Hi all!
>>
>> There is a bug in not yet merged patch
>> "block/backup: teach TOP to never copy unallocated regions"
>> in https://github.com/jnsnow/qemu bitmaps. 04 fixes it. So, I propose
>> to put 01-03 somewhere before
>> "block/backup: teach TOP to never copy unallocated regions"
>> and squash 04 into "block/backup: teach TOP to never copy
>> unallocated regions"
>>
>>
>> Hmm, don't bother with it. Simpler is fix the bug in your commit by just
>> use skip_bytes variable when initializing dirty_end.
>>
>
> OK, just use Max's fix instead of this entire 4 patch series?
>
> --js
>
Yes, I think it's OK
--
Best regards,
Vladimir
- [Qemu-devel] [PATCH 0/4] backup: fix skipping unallocated clusters, Vladimir Sementsov-Ogievskiy, 2019/08/14
- [Qemu-devel] [PATCH 3/4] block/backup: use bdrv_dirty_bitmap_next_dirty, Vladimir Sementsov-Ogievskiy, 2019/08/14
- [Qemu-devel] [PATCH 2/4] block/dirty-bitmap: add _next_dirty API, Vladimir Sementsov-Ogievskiy, 2019/08/14
- [Qemu-devel] [PATCH 1/4] block/dirty-bitmap: switch _next_dirty_area and _next_zero to int64_t, Vladimir Sementsov-Ogievskiy, 2019/08/14
- [Qemu-devel] [PATCH 4/4] block/backup: fix and improve skipping unallocated in backup_do_cow, Vladimir Sementsov-Ogievskiy, 2019/08/14
- Re: [Qemu-devel] [PATCH 0/4] backup: fix skipping unallocated clusters, Vladimir Sementsov-Ogievskiy, 2019/08/14