Re: [Qemu-devel] [PATCH for-4.1?] compat: disable edid on virtio-gpu base device

[Cornelia Huck]

On Thu, 22 Aug 2019 15:58:32 +0200
Cornelia Huck <address@hidden> wrote:

> 'edid' is a property of the virtio-gpu base device, so turning
> it off on virtio-gpu-pci is not enough (it misses -ccw). Turn
> it off on the base device instead.
> 
> Fixes: 0a71966253c8 ("edid: flip the default to enabled")
> Signed-off-by: Cornelia Huck <address@hidden>
> ---
> 
> Only just noticed this... should we still shove this into 4.1?
> Or do we need a compat 4.1.1 dance for this?
> 
> ---
>  hw/core/machine.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index 28a475ad97a3..32d1ca9abc5a 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -32,7 +32,7 @@ GlobalProperty hw_compat_4_0[] = {
>      { "secondary-vga",  "edid", "false" },
>      { "bochs-display",  "edid", "false" },
>      { "virtio-vga",     "edid", "false" },
> -    { "virtio-gpu-pci", "edid", "false" },
> +    { "virtio-gpu",     "edid", "false" },
>      { "virtio-device", "use-started", "false" },
>      { "virtio-balloon-device", "qemu-4-0-config-size", "true" },
>      { "pl031", "migrate-tick-offset", "false" },

Eh... rm fail. Please ignore that patch :)