[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] target/arm: Restrict pre-ARMv7 cpus to TCG
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] target/arm: Restrict pre-ARMv7 cpus to TCG |
Date: |
Thu, 29 Aug 2019 20:04:47 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 8/23/19 7:04 PM, Richard Henderson wrote:
> On 8/23/19 6:58 AM, Philippe Mathieu-Daudé wrote:
>> @@ -2535,6 +2544,7 @@ static const ARMCPUInfo arm_cpus[] = {
>> { .name = "arm1176", .initfn = arm1176_initfn },
>> { .name = "arm11mpcore", .initfn = arm11mpcore_initfn },
>> { .name = "cortex-m0", .initfn = cortex_m0_initfn,
>> +#endif
>> .class_init = arm_v7m_class_init },
>> { .name = "cortex-m3", .initfn = cortex_m3_initfn,
>> .class_init = arm_v7m_class_init },
>
> Ifdef is misplaced. This shouldn't even compile without CONFIG_TCG.
What a shame... I hope I messed this due to a failed rebase...
> Also, m-profile shouldn't work with kvm either, so I think the endif should go
> below cortex-m33.
Obviously.
- [Qemu-devel] [PATCH 0/4] Support disabling TCG on ARM (part 2), Philippe Mathieu-Daudé, 2019/08/23
- [Qemu-devel] [PATCH 1/4] target/arm: Restrict pre-ARMv7 cpus to TCG, Philippe Mathieu-Daudé, 2019/08/23
- [Qemu-devel] [PATCH 2/4] target/arm: Restrict R and M profiles to TCG, Philippe Mathieu-Daudé, 2019/08/23
- [Qemu-devel] [PATCH 4/4] RFC target/arm: Do not build A/M-profile cpus when using KVM, Philippe Mathieu-Daudé, 2019/08/23
- [Qemu-devel] [PATCH 3/4] RFC target/arm: Do not build pre-ARMv7 cpus when using KVM, Philippe Mathieu-Daudé, 2019/08/23
- Re: [Qemu-devel] [PATCH 3/4] RFC target/arm: Do not build pre-ARMv7 cpus when using KVM, Richard Henderson, 2019/08/23