[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] RFC target/arm: Do not build pre-ARMv7 cpus
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] RFC target/arm: Do not build pre-ARMv7 cpus when using KVM |
Date: |
Thu, 29 Aug 2019 20:08:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 8/23/19 7:12 PM, Richard Henderson wrote:
> On 8/23/19 6:58 AM, Philippe Mathieu-Daudé wrote:
>> A KVM-only build won't be able to run pre-ARMv7 cpus, disable them.
>>
>> If KVM is not enabled, they are enabled by default.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>> Sadly this does not work with --enable-tcg --enable-kvm dual config.
>> ---
>
> Huh? --enable-kvm does not imply --disable-tcg.
That would have made my life easier ;)
>> +config ARM_V4
>> + default y
>> + depends on !KVM
>> + bool
>
> This should surely be "depends on TCG".
I restricted this to KVM because this is the only one I know and got
confirmation by Peter. I don't know about other accelerators but I'll
happily take your suggestion!
Thanks,
Phil.
- [Qemu-devel] [PATCH 1/4] target/arm: Restrict pre-ARMv7 cpus to TCG, (continued)