[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2] qapi/qmp-dispatch: Fix error class for reporting
From: |
Michal Privoznik |
Subject: |
[Qemu-devel] [PATCH v2] qapi/qmp-dispatch: Fix error class for reporting disabled commands |
Date: |
Fri, 30 Aug 2019 15:29:45 +0200 |
If a command is disabled an error is reported. But due to usage
of error_setg() the class of the error is GenericError which does
not help callers in distinguishing this case from a case where a
qmp command fails regularly due to other reasons. Use
CommandNotFound error class which is much closer to the actual
root cause.
Signed-off-by: Michal Privoznik <address@hidden>
---
This is a v2 of:
https://lists.nongnu.org/archive/html/qemu-devel/2019-08/msg06327.html
diff to v1:
- Don't introduce new error class (CommandDisabled)
- Use CommandNotFound error class
qapi/qmp-dispatch.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
index 3037d353a4..bc264b3c9b 100644
--- a/qapi/qmp-dispatch.c
+++ b/qapi/qmp-dispatch.c
@@ -104,8 +104,9 @@ static QObject *do_qmp_dispatch(QmpCommandList *cmds,
QObject *request,
return NULL;
}
if (!cmd->enabled) {
- error_setg(errp, "The command %s has been disabled for this instance",
- command);
+ error_set(errp, ERROR_CLASS_COMMAND_NOT_FOUND,
+ "The command %s has been disabled for this instance",
+ command);
return NULL;
}
if (oob && !(cmd->options & QCO_ALLOW_OOB)) {
--
2.21.0
- [Qemu-devel] [PATCH v2] qapi/qmp-dispatch: Fix error class for reporting disabled commands,
Michal Privoznik <=