Re: [Qemu-devel] [PATCH v2] qapi/qmp-dispatch: Fix error class for reporting disabled commands

[Eric Blake]

On 8/30/19 8:29 AM, Michal Privoznik wrote:
> If a command is disabled an error is reported. But due to usage
> of error_setg() the class of the error is GenericError which does
> not help callers in distinguishing this case from a case where a
> qmp command fails regularly due to other reasons. Use
> CommandNotFound error class which is much closer to the actual
> root cause.
> 
> Signed-off-by: Michal Privoznik <address@hidden>
> ---
> 
> This is a v2 of:
> 
> https://lists.nongnu.org/archive/html/qemu-devel/2019-08/msg06327.html
> 
> diff to v1:
> - Don't introduce new error class (CommandDisabled)
> - Use CommandNotFound error class
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature