Re: [PATCH 1/7] qapi: Don't suppress doc generation without pragma doc-required

[Eric Blake]

On 10/1/19 2:15 PM, Markus Armbruster wrote:
> Commit bc52d03ff5 "qapi: Make doc comments optional where we don't
> need them" made scripts/qapi2texi.py fail[*] unless the schema had
> pragma 'doc-required': true.  The stated reason was inability to cope
> with incomplete documentation.
>
> When commit fb0bc835e5 "qapi-gen: New common driver for code and doc
> generators" folded scripts/qapi2texi.py into scripts/qapi-gen.py, it
> turned the failure into silent suppression.
>
> The doc generator can cope with incomplete documentation now.  I don't
> know since when, or what the problem was, or even whether it ever
> existed.
>
> Drop the silent suppression.
>
> [*] The fail part was broken, fixed in commit e8ba07ea9a.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>   scripts/qapi/doc.py    | 2 --
>   tests/Makefile.include | 1 +
>   2 files changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org