Re: [PATCH 5/7] qapi: Move gen_enum(), gen_enum_lookup() back to qapi/types.py

[Eric Blake]

On 10/1/19 2:15 PM, Markus Armbruster wrote:
> The next commit will split up qapi/common.py.  gen_enum() needs
> QAPISchemaEnumMember, and that's in the way.  Move it to qapi/types.py
> along with its buddy gen_enum_lookup().
>
> Permit me a short a digression on history: how did gen_enum() end up
> in qapi/common.py?  Commit 21cd70dfc1 "qapi script: add event support"
> duplicated qapi-types.py's gen_enum() and gen_enum_lookup() in
> qapi-event.py.  Simply importing them would have been cleaner, but
> wasn't possible as qapi-types.py was a program, not a module.  Commit
> efd2eaa6c2 "qapi: De-duplicate enum code generation" de-duplicated by
> moving them to qapi.py, which was a module.
>
> Since then, program qapi-types.py has morphed into module types.py.
> It's where gen_enum() and gen_enum_lookup() started, and where they
> belong.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>   scripts/qapi/common.py | 59 ------------------------------------------
>   scripts/qapi/events.py |  1 +
>   scripts/qapi/types.py  | 59 ++++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 60 insertions(+), 59 deletions(-)
Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org