[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 2 PATCH 03/16] hw/i386: Introduce X86CPUTopoInfo t
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [RFC 2 PATCH 03/16] hw/i386: Introduce X86CPUTopoInfo to contain topology info |
Date: |
Fri, 11 Oct 2019 00:54:06 -0300 |
On Fri, Sep 06, 2019 at 07:11:57PM +0000, Moger, Babu wrote:
> This is an effort to re-arrange few data structure for better
> readability. Add X86CPUTopoInfo which will have all the topology
> informations required to build the cpu topology. There is no
> functional changes.
>
> Signed-off-by: Babu Moger <address@hidden>
> ---
[...]
> +typedef struct X86CPUTopoInfo {
> + unsigned numa_nodes;
> + unsigned nr_sockets;
> + unsigned nr_dies;
> + unsigned nr_cores;
> + unsigned nr_threads;
> +} X86CPUTopoInfo;
With more complex topologies, the meaning of each of those fields
may be ambiguous. e.g.: is nr_cores cores per die, cores per
ccx, or cores per socket? Maybe we should use this opportunity
to use more explicit names like threads_per_core, cores_per_die,
dies_per_socket.
--
Eduardo