[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 8/8] target/avr: Register AVR support with th
From: |
Sarah Harris |
Subject: |
Re: [Qemu-devel] [PATCH v1 8/8] target/avr: Register AVR support with the rest of QEMU, the build system, and the MAINTAINERS file |
Date: |
Thu, 17 Oct 2019 14:11:59 +0100 |
Hi Philippe,
I've checked and yes, I can make time to review patches.
This is part of my current paid work, so when my contract eventually ends I
will likely have to step down as reviewer.
I'll have notice of that happening some time before, so I can pass that along
when it comes.
This message comes from my work email so the details should be correct, i.e.
Sarah Harris <address@hidden>
Kind regards,
Sarah Harris
On Sat, 12 Oct 2019 09:31:07 +0200
Philippe Mathieu-Daudé <address@hidden> wrote:
> Hi Sarah,
>
> On 5/10/19 1:17 PM, Sarah Harris wrote:
> > Hi Richard,
> >
> > Having discussed with my colleagues, we don't have the resources to
> > maintain this.
> > If you wanted to take up Michael's offer then I'm happy to respond to
> > queries and provide minor fixes.
> > Otherwise, we will make our repository publicly available in the near
> > future for anyone who wants to use it.
>
> Would you agree to be listed as reviewer for AVR (Michael being the
> maintainer)?
>
> M: Mail patches to: FullName <address@domain>
> Maintainers are looking after a certain area and must be CCed on
> patches. They are considered the main contact point.
> R: Designated reviewer: FullName <address@domain>
> These reviewers should be CCed on patches.
> Reviewers are familiar with the subject matter and provide feedback
> even though they are not maintainers.
>
> > Kind regards,
> > Sarah Harris
> >
> > On Sun, 5 May 2019 09:10:00 -0700
> > Michael Rolnik <address@hidden> wrote:
> >
> >> Hi Richard.
> >>
> >> I can maintain it
> >>
> >> Sent from my cell phone, please ignore typos
> >>
> >> On Sun, May 5, 2019, 8:57 AM Richard Henderson <address@hidden>
> >> wrote:
> >>
> >>> On 5/4/19 1:36 AM, Sarah Harris wrote:
> >>>> Signed-off-by: Sarah Harris <address@hidden>
> >>> ...
> >>>>
> >>>> +AVR
> >>>> +M: Michael Rolnik <address@hidden>
> >>>> +S: Odd Fixes
> >>>> +F: target-avr/
> >>>> +F: hw/avr/
> >>>> +
> >>>
> >>> This is not how things work. Michael wasn't up to maintaining the code 2
> >>> years
> >>> ago; that's why it was never committed.
> >>>
> >>> You would need to maintain this yourself, and for more than "Odd Fixes".
> >>>
> >>>
> >>> r~
> >>>
> >
>