[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 20/32] hw/i386/pc: Extract pc_gsi_create()
|
From: |
Thomas Huth |
|
Subject: |
Re: [PATCH 20/32] hw/i386/pc: Extract pc_gsi_create() |
|
Date: |
Thu, 17 Oct 2019 17:33:46 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 15/10/2019 18.26, Philippe Mathieu-Daudé wrote:
> The GSI creation code is common to all PC machines, extract the
> common code.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/i386/pc.c | 15 +++++++++++++++
> hw/i386/pc_piix.c | 9 +--------
> hw/i386/pc_q35.c | 9 +--------
> include/hw/i386/pc.h | 2 ++
> 4 files changed, 19 insertions(+), 16 deletions(-)
Is this really needed for this series here, or should this and the
following patches maybe rather be handled seperately?
Anyway, it looks like a good modification, so:
Reviewed-by: Thomas Huth <address@hidden>
- [PATCH 16/32] piix4: add a mc146818rtc controller as specified in datasheet, (continued)
- [PATCH 16/32] piix4: add a mc146818rtc controller as specified in datasheet, Philippe Mathieu-Daudé, 2019/10/15
- [PATCH 17/32] hw/mips/mips_malta: Create IDE hard drive array dynamically, Philippe Mathieu-Daudé, 2019/10/15
- [PATCH 18/32] hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create(), Philippe Mathieu-Daudé, 2019/10/15
- [PATCH 19/32] hw/isa/piix4: Move piix4_create() to hw/isa/piix4.c, Philippe Mathieu-Daudé, 2019/10/15
- [PATCH 20/32] hw/i386/pc: Extract pc_gsi_create(), Philippe Mathieu-Daudé, 2019/10/15
- [PATCH 21/32] hw/i386/pc: Reduce gsi_handler scope, Philippe Mathieu-Daudé, 2019/10/15
- Re: [PATCH 21/32] hw/i386/pc: Reduce gsi_handler scope, Thomas Huth, 2019/10/17
- [PATCH 22/32] hw/i386/pc: Move gsi_state creation code, Philippe Mathieu-Daudé, 2019/10/15
- [PATCH 23/32] hw/i386/pc: Extract pc_i8259_create(), Philippe Mathieu-Daudé, 2019/10/15
- [PATCH 24/32] hw/i386/pc: Remove kvm_i386.h include, Philippe Mathieu-Daudé, 2019/10/15
- [PATCH 25/32] hw/pci-host/piix: Extract piix3_create(), Philippe Mathieu-Daudé, 2019/10/15