[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 21/32] hw/i386/pc: Reduce gsi_handler scope
From: |
Thomas Huth |
Subject: |
Re: [PATCH 21/32] hw/i386/pc: Reduce gsi_handler scope |
Date: |
Thu, 17 Oct 2019 17:41:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 15/10/2019 18.26, Philippe Mathieu-Daudé wrote:
> pc_gsi_create() is the single function that uses gsi_handler.
> Make it a static variable.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/i386/pc.c | 2 +-
> include/hw/i386/pc.h | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index a7597c6c44..59de0c8a1f 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -346,7 +346,7 @@ GlobalProperty pc_compat_1_4[] = {
> };
> const size_t pc_compat_1_4_len = G_N_ELEMENTS(pc_compat_1_4);
>
> -void gsi_handler(void *opaque, int n, int level)
> +static void gsi_handler(void *opaque, int n, int level)
> {
> GSIState *s = opaque;
>
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index d0c6b9d469..75b44e156c 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -172,8 +172,6 @@ typedef struct GSIState {
> qemu_irq ioapic_irq[IOAPIC_NUM_PINS];
> } GSIState;
>
> -void gsi_handler(void *opaque, int n, int level);
> -
> GSIState *pc_gsi_create(qemu_irq **irqs, bool pci_enabled);
>
> /* vmport.c */
>
Reviewed-by: Thomas Huth <address@hidden>
- Re: [PATCH 18/32] hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create(), (continued)
- [PATCH 22/32] hw/i386/pc: Move gsi_state creation code, Philippe Mathieu-Daudé, 2019/10/15
- [PATCH 23/32] hw/i386/pc: Extract pc_i8259_create(), Philippe Mathieu-Daudé, 2019/10/15
- [PATCH 24/32] hw/i386/pc: Remove kvm_i386.h include, Philippe Mathieu-Daudé, 2019/10/15
- [PATCH 25/32] hw/pci-host/piix: Extract piix3_create(), Philippe Mathieu-Daudé, 2019/10/15
- [PATCH 26/32] hw/pci-host/piix: Move RCR_IOPORT register definition, Philippe Mathieu-Daudé, 2019/10/15