qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation


From: address@hidden
Subject: RE: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation
Date: Fri, 18 Oct 2019 08:51:20 +0000

> > Even simpler: allow O_PATH descriptors for f*xattr().
> 
> Attached patch.  Will post shortly.
> 
> However, I think it would make sense to fix virtiofsd as well, as this will 
> take time to percolate down, even if Al doesn't find
> anything wrong with it.

Thanks for you comments.

Though I'm still learning virtiofsd code, if nobody will try I'm willing to 
work on this.

> Doing unshare(CLONE_FS) after thread startup seems safe, though must be 
> careful to change the working directory to the root of
> the mount
> *before* starting any threads.

I think working directry is changed in setup_sandbox() -> 
setup_mount_namespace() -> setup_pivot_root().
So, can we just add unshare(CLONE_FS) in fv_queue_worker()?

Sorry if I'm totally misunderstood the situation.

Thanks,
Misono

reply via email to

[Prev in Thread] Current Thread [Next in Thread]