Re: [PATCH v2] net: add tulip (dec21143) driver

[Peter Maydell]

On Tue, 22 Oct 2019 at 16:54, Sven Schnelle <address@hidden> wrote:
>
> This adds the basic functionality to emulate a Tulip NIC.
>
> Implemented are:
>
> - RX and TX functionality
> - Perfect Frame Filtering
> - Big/Little Endian descriptor support
> - 93C46 EEPROM support
> - LXT970 PHY
>
> Not implemented, mostly because i had no OS using these functions:
>
> - Imperfect frame filtering
> - General Purpose Timer
> - Transmit automatic polling
> - Boot ROM support
> - SIA interface
> - Big/Little Endian data buffer conversion
>
> Successfully tested with the following Operating Systems:
>
> - MSDOS with Microsoft Network Client 3.0 and DEC ODI drivers
> - HPPA Linux
> - Windows XP
> - HP-UX
>
> Signed-off-by: Sven Schnelle <address@hidden>

Reviewed-by: Peter Maydell <address@hidden>

There are a couple of minor wrong-indent nits:

> +static void tulip_update_ts(TULIPState *s, int state)
> +{
> +        s->csr[5] &= ~(CSR5_TS_MASK << CSR5_TS_SHIFT);
> +        s->csr[5] |= (state & CSR5_TS_MASK) << CSR5_TS_SHIFT;
> +        trace_tulip_tx_state(tulip_tx_state_name(state));
> +}

> +struct tulip_descriptor {
> +        uint32_t status;
> +        uint32_t control;
> +        uint32_t buf_addr1;
> +        uint32_t buf_addr2;
> +};

but maybe Jason can fix those up when he takes the patch ?

thanks
-- PMM