Re: [PATCH v6 00/12] target/mips: Misc cleanups for September/October 2019

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v6 00/12] target/mips: Misc cleanups for September/October 2019
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
36112c6 target/mips: msa: Split helpers for ASUB_<S|U>.<B|H|W|D>
c385d15 target/mips: msa: Split helpers for HSUB_<S|U>.<H|W|D>
1cb06f9 target/mips: msa: Split helpers for PCK<EV|OD>.<B|H|W|D>
c163234 target/mips: msa: Split helpers for S<LL|RA|RAR|RL|RLR>.<B|H|W|D>
e291f35 target/mips: msa: Split helpers for HADD_<S|U>.<H|W|D>
6e9e5a5 target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>
d6312d1 target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D>
8825acf target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D>
fc46b54 target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D>
217fbe2 MAINTAINERS: Update mail address of Aleksandar Rikalo
5e0227b target/mips: Clean up op_helper.c
a8fa795 target/mips: Clean up helper.c

=== OUTPUT BEGIN ===
1/12 Checking commit a8fa7957997d (target/mips: Clean up helper.c)
2/12 Checking commit 5e0227b2346c (target/mips: Clean up op_helper.c)
ERROR: spaces required around that '*' (ctx:WxV)
#1059: FILE: target/mips/op_helper.c:3871:
+                                  float_status *status)              \
                                                ^

total: 1 errors, 0 warnings, 1681 lines checked

Patch 2/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/12 Checking commit 217fbe216ae8 (MAINTAINERS: Update mail address of 
Aleksandar Rikalo)
4/12 Checking commit fc46b54fe0a0 (target/mips: msa: Split helpers for 
<MAX|MIN>_A.<B|H|W|D>)
5/12 Checking commit 8825acf5951f (target/mips: msa: Split helpers for 
<MAX|MIN>_<S|U>.<B|H|W|D>)
6/12 Checking commit d6312d1d6fe6 (target/mips: msa: Split helpers for 
ILV<EV|OD|L|R>.<B|H|W|D>)
7/12 Checking commit 6e9e5a5404a5 (target/mips: msa: Split helpers for 
ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>)
8/12 Checking commit e291f3532f5d (target/mips: msa: Split helpers for 
HADD_<S|U>.<H|W|D>)
9/12 Checking commit c16323490f9c (target/mips: msa: Split helpers for 
S<LL|RA|RAR|RL|RLR>.<B|H|W|D>)
10/12 Checking commit 1cb06f9ae607 (target/mips: msa: Split helpers for 
PCK<EV|OD>.<B|H|W|D>)
11/12 Checking commit c385d15ca204 (target/mips: msa: Split helpers for 
HSUB_<S|U>.<H|W|D>)
12/12 Checking commit 36112c61daf9 (target/mips: msa: Split helpers for 
ASUB_<S|U>.<B|H|W|D>)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden