Re: [PATCH v6 00/12] target/mips: Misc cleanups for September/October 2019

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v6 00/12] target/mips: Misc cleanups for September/October 2019
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
4a47a90 target/mips: msa: Split helpers for ASUB_<S|U>.<B|H|W|D>
80b4880 target/mips: msa: Split helpers for HSUB_<S|U>.<H|W|D>
045f415 target/mips: msa: Split helpers for PCK<EV|OD>.<B|H|W|D>
861d76a target/mips: msa: Split helpers for S<LL|RA|RAR|RL|RLR>.<B|H|W|D>
39d4345 target/mips: msa: Split helpers for HADD_<S|U>.<H|W|D>
a86a459 target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>
5714c4f target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D>
17d744e target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D>
bd4d22e target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D>
e271939 MAINTAINERS: Update mail address of Aleksandar Rikalo
9938bd3 target/mips: Clean up op_helper.c
fc20b79 target/mips: Clean up helper.c

=== OUTPUT BEGIN ===
1/12 Checking commit fc20b79dea40 (target/mips: Clean up helper.c)
2/12 Checking commit 9938bd3b2fb2 (target/mips: Clean up op_helper.c)
ERROR: spaces required around that '*' (ctx:WxV)
#1059: FILE: target/mips/op_helper.c:3871:
+                                  float_status *status)              \
                                                ^

total: 1 errors, 0 warnings, 1681 lines checked

Patch 2/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/12 Checking commit e2719394e1b4 (MAINTAINERS: Update mail address of 
Aleksandar Rikalo)
4/12 Checking commit bd4d22e72ce9 (target/mips: msa: Split helpers for 
<MAX|MIN>_A.<B|H|W|D>)
5/12 Checking commit 17d744ed246a (target/mips: msa: Split helpers for 
<MAX|MIN>_<S|U>.<B|H|W|D>)
6/12 Checking commit 5714c4f6f3ae (target/mips: msa: Split helpers for 
ILV<EV|OD|L|R>.<B|H|W|D>)
7/12 Checking commit a86a45905bb5 (target/mips: msa: Split helpers for 
ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>)
8/12 Checking commit 39d4345977ca (target/mips: msa: Split helpers for 
HADD_<S|U>.<H|W|D>)
9/12 Checking commit 861d76a00b7b (target/mips: msa: Split helpers for 
S<LL|RA|RAR|RL|RLR>.<B|H|W|D>)
10/12 Checking commit 045f415cf74c (target/mips: msa: Split helpers for 
PCK<EV|OD>.<B|H|W|D>)
11/12 Checking commit 80b488087528 (target/mips: msa: Split helpers for 
HSUB_<S|U>.<H|W|D>)
12/12 Checking commit 4a47a90d1e70 (target/mips: msa: Split helpers for 
ASUB_<S|U>.<B|H|W|D>)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden