Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps()

From:	Eric Blake
Subject:	Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps()
Date:	Tue, 22 Oct 2019 20:13:35 -0500
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1

On 10/20/19 6:11 AM, Tao Xu wrote:

To convert strings with time suffixes to numbers, support time unit are
"ps" for picosecond, "ns" for nanosecond, "us" for microsecond, "ms"
for millisecond or "s" for second.


I haven't yet reviewed the patch itself, but my off-hand observation:

picosecond is probably too narrow to ever be useful. POSIX interfacesonly go down to nanoseconds, and when you start adding in vmexit delaytimes and such, we're lucky when we get anything better than microsecondaccuracies. Supporting just three sub-second suffixes instead of fourwould slightly simplify the code, and not cost you any real precision.


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v13 02/12] tests/cutils: Add test for qemu_strtotime_ps(), (continued)
- [PATCH v13 02/12] tests/cutils: Add test for qemu_strtotime_ps(), Tao Xu, 2019/10/20
- [PATCH v13 04/12] tests: Add test for QAPI builtin type time, Tao Xu, 2019/10/20
- [PATCH v13 06/12] numa: Extend CLI to provide memory latency and bandwidth information, Tao Xu, 2019/10/20
  - Re: [PATCH v13 06/12] numa: Extend CLI to provide memory latency and bandwidth information, Igor Mammedov, 2019/10/22
    - Re: [PATCH v13 06/12] numa: Extend CLI to provide memory latency and bandwidth information, Tao Xu, 2019/10/22
  - Re: [PATCH v13 06/12] numa: Extend CLI to provide memory latency and bandwidth information, Igor Mammedov, 2019/10/23
- [PATCH v13 08/12] numa: Extend CLI to provide memory side cache information, Tao Xu, 2019/10/20
- [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps(), Tao Xu, 2019/10/20
  - Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps(), Eduardo Habkost, 2019/10/22
    - Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps(), Tao Xu, 2019/10/23
  - Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps(), Eric Blake <=
    - Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps(), Tao Xu, 2019/10/22
  - Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps(), Daniel P . Berrangé, 2019/10/24
    - Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps(), Eduardo Habkost, 2019/10/24
    - Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps(), Tao Xu, 2019/10/24
- [PATCH v13 05/12] numa: Extend CLI to provide initiator information for numa nodes, Tao Xu, 2019/10/20
  - Re: [PATCH v13 05/12] numa: Extend CLI to provide initiator information for numa nodes, Igor Mammedov, 2019/10/21
    - Re: [PATCH v13 05/12] numa: Extend CLI to provide initiator information for numa nodes, Tao Xu, 2019/10/21
- [PATCH v13 07/12] numa: Calculate hmat latency and bandwidth entry list, Tao Xu, 2019/10/20
- [PATCH v13 10/12] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s), Tao Xu, 2019/10/20
- [PATCH v13 09/12] hmat acpi: Build Memory Proximity Domain Attributes Structure(s), Tao Xu, 2019/10/20

Prev by Date: Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps()
Next by Date: Re: [PATCH v10 3/3] iotests: test nbd reconnect
Previous by thread: Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps()
Next by thread: Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps()
Index(es):
- Date
- Thread